-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-layered directory structure #194
Comments
I like the slightly flatter one. No strong preference |
I moved FixedDecimal to @sffc would you like me to also move all data provider code to |
And one more question i have is about the meta-packages. Last q - in your proposal |
@zbraniecki servo used to have a |
TBH, I'm still fuzzy on the difference between utils and components.
No; let's adopt Option 4 for now and keep them under components. I could see an argument for moving some of them into utils, but I'm not sure what the advantage is of making a new top-level directory. |
In #18 we decided to make a top-level
/components
directory. I like this, but I'm also thinking that it might be good to have an extra layer of abstraction. We've come across several types of components so far:How should we structure these in the repository?
FYI, ICU4C is split into four categories:
Here's one possible layout, with an emphasis on structure:
/
components/
locales/
language-info/
(crate)language-matcher/
(crate)locale/
(crate)numbers/
fixed-decimal/
(crate)number-format/
(crate)unicode/
unicode-set/
(crate)unicode-props/
(crate)udata/
cldr-json-data-provider/
(crate)data-provider/
(crate)fs-data-provider/
(crate)fs-data-exporter/
(crate)strings/
writeable/
(crate)resources/
json/
(root of JSON data directory, latest version)Here's another possible layout, with an emphasis on flatness:
/
components/
language-info/
(crate)language-matcher/
(crate)locale/
(crate)number-format/
(crate)unicode-props/
(crate)udata/
cldr-json-data-provider/
(crate)data-provider/
(crate)fs-data-provider/
(crate)fs-data-exporter/
(crate)json-data/
(root of JSON data directory, latest version)utils/
writeable/
(crate)fixed-decimal/
(crate)unicode-set/
(crate)Another, simpler layout:
/
components/
language-info/
(crate)language-matcher/
(crate)locale/
(crate)number-format/
(crate)unicode-props/
(crate)cldr-json-data-provider/
(crate)data-provider/
(crate)fs-data-provider/
(crate)fs-data-exporter/
(crate)writeable/
(crate)fixed-decimal/
(crate)unicode-set/
(crate)resources/
json-data/
(root of JSON data directory, latest version)Option 4:
/
components/
language-info/
(crate)language-matcher/
(crate)locale/
(crate)number-format/
(crate)unicode-props/
(crate)cldr-json-data-provider/
(crate)data-provider/
(crate)fs-data-provider/
(crate)fs-data-exporter/
(crate)utils/
writeable/
(crate)fixed-decimal/
(crate)unicode-set/
(crate)resources/
json-data/
(root of JSON data directory, latest version)Option 5:
/
components/
language-info/
(crate)language-matcher/
(crate)locale/
(crate)number-format/
(crate)unicode-props/
(crate)udata/
cldr-json-data-provider/
(crate)data-provider/
(crate)fs-data-provider/
(crate)fs-data-exporter/
(crate)utils/
writeable/
(crate)fixed-decimal/
(crate)unicode-set/
(crate)resources/
json-data/
(root of JSON data directory, latest version)Thoughts?
@Manishearth
The text was updated successfully, but these errors were encountered: