Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies will be deleted when closing Chromium on Windows even when disabled in the settings. #378

Closed
onabi opened this issue Apr 1, 2018 · 21 comments
Labels

Comments

@onabi
Copy link

onabi commented Apr 1, 2018

The cookies get cleared when closing the browser even after disabling it in the settings.
cookies
This is my build. http://www43.zippyshare.com/v/KGfC4FUJ/file.html

@CardealRusso
Copy link

thanks for the virus

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

Onabi, thank you for sharing it. Why, this build is connecting to clients2.google.com ?

@onabi
Copy link
Author

onabi commented Apr 1, 2018

It's not a virus, it's the package I got after building it by following the instructions and as for why it is connecting to clients2.google.com I have no idea.

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

Ublock Origin is crashing at start up. Something to do with the WebRTC?

@onabi
Copy link
Author

onabi commented Apr 1, 2018

@ribatamu gorhill/uBlock#533 That fixed it for me.
I don't recommend using my build though as it may be broken...

@squalus
Copy link
Member

squalus commented Apr 1, 2018

You compiled without webrtc? I got build errors when I tried to do that.

@squalus
Copy link
Member

squalus commented Apr 1, 2018

With my Windows build I don't see problems persisting cookies, nor is it connecting to google.

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

Squalus, could you share your build?

@squalus
Copy link
Member

squalus commented Apr 1, 2018

@ribatamu /~https://github.com/squalus/ungoogled-chromium-winbuild/releases/tag/65.0.3325.181-1

I have a PR open to put it up on the main site

@onabi
Copy link
Author

onabi commented Apr 1, 2018

After trying on another windows 10 installation, cookies seem to be saved properly, my bad, I should have done it before opening an issue.

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

Squalus, I have the same issue with your build. The build is connecting to clients2.google.com and Ublock Origin is crashing at start up. Do you have this issues on your end?

@squalus
Copy link
Member

squalus commented Apr 1, 2018

I just tested in a clean Windows Server 2016 install. I don't see a connection to google or anywhere else on startup. I do see the same problem with uBlock Origin crashing though. A few other extensions I tested seem to work fine.

@squalus
Copy link
Member

squalus commented Apr 1, 2018

It is something related to the webrtc check. You can get it working if you comment out code in js/is-webrtc-supported.js.

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

I am not sure if anybody is using, but there is extension called privacy manager by saroyanm... After installation if I mouse click on this extension icon, Ungoogled Chromium is closing.

@squalus
Copy link
Member

squalus commented Apr 1, 2018

new self.RTCPeerConnection(null) causes a crash on Windows but not Linux

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

The connections to clients2.google.com are not caused by Ungoogled Chromium. I used additional software on my system, which is installing crx file and reg key in the registry, which is causing this connections.

@ribatamu
Copy link

ribatamu commented Apr 1, 2018

Squalus, Ungoogled Chromium is closing, when you open new incognito window. That's without any extensions.

@squalus
Copy link
Member

squalus commented Apr 1, 2018

Same here

@onabi
Copy link
Author

onabi commented Apr 1, 2018

@ribatamu My build closes too when using incognito mode.

@squalus
Copy link
Member

squalus commented Apr 1, 2018

So it seems there's two major bugs in the Windows build:

  • new self.RTCPeerConnection(null) crashes
  • Incognito mode crashes

@Eloston
Copy link
Member

Eloston commented Apr 2, 2018

Opened issues #380 and #381 to resolve new issues.

clients2.google.com could be extensions trying to do an update check. You can try without extensions to see if any connections to clients2.google.com still go through.

Closing this one with invalid due to #378 (comment)

@Eloston Eloston closed this as completed Apr 2, 2018
@Eloston Eloston added the invalid label Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants