Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG in - Prevent WebRTC from leaking local IP addresses #1290

Closed
8 tasks
ballios opened this issue Oct 12, 2020 · 10 comments
Closed
8 tasks

BUG in - Prevent WebRTC from leaking local IP addresses #1290

ballios opened this issue Oct 12, 2020 · 10 comments
Labels
invalid not a uBlock issue

Comments

@ballios
Copy link

ballios commented Oct 12, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Bad issue appeared!
In uBlock Origin v1.30.2 when "Prevent WebRTC from leaking local IP addresses" is On - WebRTC exposed my public IP address!
And when "Prevent WebRTC from leaking local IP addresses" is OFF - WebRTC not available.
Thus, this uBlock's privace option is working vice versa!
Please fix it!

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior:

[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

  • uBlock Origin version: uBlock Origin v1.30.2
  • Browser Name and version: Google Chrome 86.0.4240.75
  • Operating System and version: Windows 10 (v.2004)
@uBlock-user
Copy link
Contributor

uBlock-user commented Oct 12, 2020

On - WebRTC exposed my public IP address!

By-design - /~https://github.com/gorhill/uBlock/wiki/Prevent-WebRTC-from-leaking-local-IP-address

And when "Prevent WebRTC from leaking local IP addresses" is OFF - WebRTC not available.

URL ? Fill the template as asked, do not bypass it !

@uBlock-user uBlock-user added the invalid not a uBlock issue label Oct 12, 2020
@gorhill
Copy link
Member

gorhill commented Oct 12, 2020

when "Prevent WebRTC from leaking local IP addresses" is On - WebRTC exposed my public IP address!

Public IP address is not a local IP address, see "Prevent WebRTC from leaking local IP address" (literally the documentation linked to from the dashboard):

Keep in mind that this feature is to prevent leakage of your non-internet-facing IP adresses. The purpose of this feature is not to hide your current internet-facing IP address -- so be cautious to not misinterpret the results of the tests above.

@timeneverdie
Copy link

timeneverdie commented Oct 29, 2020

when "Prevent WebRTC from leaking local IP addresses" is On - WebRTC exposed my public IP address!

Public IP address is not a local IP address, see "Prevent WebRTC from leaking local IP address" (literally the documentation linked to from the dashboard):

Keep in mind that this feature is to prevent leakage of your non-internet-facing IP adresses. The purpose of this feature is not to hide your current internet-facing IP address -- so be cautious to not misinterpret the results of the tests above.

Sir, I found the same problem in latest Chrome. The option of uBlock which can prevent public IP address leak before, but now it failed. I don't know if Chrome changes its mechanism, however it works fine before, even though you say that only works with local IP address. If the only method is to close webrtc in chrome://flag?

@gorhill
Copy link
Member

gorhill commented Oct 29, 2020

@timeneverdie What fails? Please, read carefully the documentation about what the feature does. Claims of failure must be accompanied by actual detailed repro steps if after reading the documentation carefully you actually see the option failing from doing what it's supposed to do. This is an often misunderstood feature, be sure it's not your case. Chrome does not have the same setting as Opera, so it appears you are just misunderstanding the setting.

@timeneverdie
Copy link

@timeneverdie What fails? Please, read carefully the documentation about what the feature does. Claims of failure must be accompanied by actual detailed repro steps if after reading the documentation carefully you actually see the option failing from doing what it's supposed to do. This is an often misunderstood feature, be sure it's not your case. Chrome does not have the same setting as Opera, so it appears you are just misunderstanding the setting.

I have tested webrtc leak by some websites tools. They can find my public IP address even though I use proxy. However, they reported no IP address leak before. So I think uBlock's feature failed.

image

I just searched some information and I found above. I think maybe firefox is the only option for security. What do you think?

@gorhill
Copy link
Member

gorhill commented Oct 29, 2020

They can find my public IP address even though I use proxy

Can they still find your IP address when you uncheck the option in uBO?

@timeneverdie
Copy link

They can find my public IP address even though I use proxy

Can they still find your IP address when you uncheck the option in uBO?

Yes, still got my real IP address under proxy. (unchecked the option)

@gorhill
Copy link
Member

gorhill commented Oct 29, 2020

Follow #1297, I haven't decided yet but exposing the different WebRTC levels in uBO's user interface is something I am considering.

@timeneverdie
Copy link

Follow #1297, I haven't decided yet but exposing the different WebRTC levels in uBO's user interface is something I am considering.

Thanks for your reply.

I have checked the wiki: /~https://github.com/gorhill/uBlock/wiki/Prevent-WebRTC-from-leaking-local-IP-address

For example, if you use a VPN, your internet-facing IP address is that of the VPN, so your ISP-provided IP address should not be visible to outside world with this setting checked. However, if you are not behind any VPN or proxy, your ISP-provided IP address will be visible regardless of this setting.

So here is my problem: I have hided my real IP (ISP IP) successfully before(I'm sure, but that was two or three years ago), but now it failed. (under proxy)

I am confused too.

@gorhill
Copy link
Member

gorhill commented Oct 29, 2020

https://developer.chrome.com/extensions/privacy#type-IPHandlingPolicy:

"default", "default_public_and_private_interfaces", "default_public_interface_only", or "disable_non_proxied_udp"

uBO uses default_public_interface_only when the option is checked. That's the purpose of the setting.

Related: https://bugs.chromium.org/p/chromium/issues/detail?id=874254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

4 participants