-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy 2 pinning #403
Comments
Ah, that's good then. Can you push the button to make a release (0.2) anyway? How do we switch to ruff linting? |
I've just done it over at tskit: tskit-dev/tskit#2952 |
Thanks. Shall I make that switch (mostly in |
I'm happy to pick that up - they'll likely be lots of errors to fix, I have some automated tools for some of them from the tskit switch. |
Oh, that's kind, thanks. |
If there's going to be a lot of changes to files across the board, mind waiting until I'm done with the singleton phasing (almost there)? Else there'll be a boatload of merge conflicts |
Maybe we can simply release v2.0 now without the ruff linting, then switch ruff on after the singleton stuff drops, to make v0.2.1? |
I don't think there's any hurry with ruff, the numba dependency will be safe for numpy 2 for quite a while. No harm in scheduling the change for immediately after current release though |
Yeah, happy to leave ruff till after the release. @nspope get your PR merged before ruff for sure! |
Closing this as we've decided to release using numba as the implicit pin and to do ruff after release. |
Great. Let me know if I need to do anything to help push a new release version. |
Thanks @benjeffery ! |
I've looked into this, and tsdate is implicitly pinned to
numpy<1.27
via the dependency onnumba
. I don't see any other reason why tsdate should be incompatible with numpy 2, so I suggest we don't pin and and check compatibility when a numba release candidate is out. Switching to the numpy ruff linting in the meantime would seem wise.The text was updated successfully, but these errors were encountered: