Companion improvements

[mifi]

Discovered while working on #3159:

• speed improvement: For TUS uploads (and I believe form upload), we don't need to download file first, even if its size is unknown. I think those can both handle unknown length streams
• pause/resume tus upload does not work properly with streamingUpload: true (currently defaults to false), due to this issue: abort() followed by start() is broken on non-file streams tus/tus-js-client#275
• We should consider adding support for URL objects instead of using path
• Improve companion tests / global, singleton state #3545

Discovered while working on #3953

• upgrade got to v12, so that we can get rid of the unmaintained form-data module, see Remove request and form-data from companion #3496. This might be a big task because we possibly would need to rewrite Companion to ESM.
• /logout endpoint in companion has side effects and I think should not be a GET (this is a client-server API breaking change so maybe it won't happen ever)

  uppy/packages/@uppy/companion/src/companion.js

  Line 116 in 727fbc6

  app.get('/:providerName/logout', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.logout)

Moved from trello

• make Instagrams thumbnails smaller, maybe transcode them on-the-fly in companion. Related: Thumbnails from cloud companion uploaders (Google Drive, Dropbox, etc) sometimes do not display before upload #5389

Write tests:

• Unsplash, similar to all the other providers
• test for:

  uppy/packages/@uppy/companion/src/server/Uploader.js

  Line 621 in 84a98c6

  extraData: getRespObj(err.response),

• test for:

  uppy/packages/@uppy/companion/src/server/helpers/request.js

  Line 155 in 84a98c6

  // todo add unit test for this

• test for:

  uppy/packages/@uppy/companion/src/server/helpers/utils.js

  Line 160 in 84a98c6

  reject(Object.assign(new Error(), { response: { body: JSON.parse(err.response.body) } }))

[Murderlon]

Can we merge this issue into #3180? and perhaps the last point can go into #3268?

[mifi]

I think this issue is different from #3180. #3180 is about small breaking changes we want to do in the next major. This issue is more about non-breaking changes which would improve companion, but I didn't want to make an issue for each of the improvements, as we would end up with very many issues then. And I didn't find any other place they fit in, so I put them here.

I'll move the last point to #3268 👍

[Acconut]

Regarding:

pause/resume tus upload does not work properly with streamingUpload: true (currently defaults to false), due to this issue: tus/tus-js-client#275

The linked issue is now fixed in tus-js-client v3.0.0-0 (still a prerelease). tus-js-client is able to properly pause and resume even when the data source is an in-memory stream. Note that tus-js-client will create an in-memory buffer of the size defined in its chunkSize option.

Just wanted to let you know that the depending issue in tus-js-client is now resolved.

[mifi]

Great! From my testing it seems to be working nicely. Shall we make companion depend on v3.0.0-0 or do you want to release this as a v2 in tus-js-client?

[Acconut]

Uppy now uses tus-js-client v3. Is there anything else that needs to be done (in uppy or tus-js-client) for this issue here?

[mifi]

Not that I know of. AFAIK Tus supports uploading streams with unknown length so it should be good.