Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make indexmap dependency optional #810

Open
zeenix opened this issue Nov 13, 2024 · 2 comments
Open

Make indexmap dependency optional #810

zeenix opened this issue Nov 13, 2024 · 2 comments
Labels
A-parse Area: Parsing TOML C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.

Comments

@zeenix
Copy link
Contributor

zeenix commented Nov 13, 2024 •
edited
Loading

Sometimes one just needs parsing/deserialization and it would be great to be able to do that with this crate w/o having to drag indexmap and its deps along only for that (See bkchr/proc-macro-crate#37). I believe the order is only important when writing back data after reading it but not, when only parsing so this should be possible?
@epage
Copy link
Member

epage commented Nov 13, 2024

I experimented with this for a bit but ran into some problems but can't remember what they were.

#808 might allow us to drop it regardless.

@epage epage added C-enhancement Category: Raise on the bar on expectations A-parse Area: Parsing TOML labels Nov 13, 2024
@epage
Copy link
Member

epage commented Nov 13, 2024

Hmm, we made ourselves further entrenched into indexmap by using the Raw API.

@epage epage added the M-breaking-change Meta: Implementing or merging this will introduce a breaking change. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parse Area: Parsing TOML C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeenix @epage