From 117ff937dd70e500bb8dad06b5e221267bfd8f7b Mon Sep 17 00:00:00 2001 From: James Balamuta Date: Wed, 26 Apr 2017 10:08:32 -0500 Subject: [PATCH] Address quotation concerns and fix doi --- DESCRIPTION | 12 ++++++------ cran-comments.md | 9 +++++++++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index ec4d835..48e2dca 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -2,16 +2,16 @@ Package: dina Type: Package Title: Bayesian Estimation of DINA Model Version: 1.0.2 -Date: 2017-04-25 +Date: 2017-04-26 Authors@R: c(person("Steven Andrew", "Culpepper", role = c("aut", "cph","cre"), email = "sculpepp@illinois.edu")) -Description: Estimate the Deterministic Input, Noisy ``And'' Gate (DINA) +Description: Estimate the Deterministic Input, Noisy "And" Gate (DINA) cognitive diagnostic model parameters using the Gibbs sampler described - by Culpepper (2015) . + by Culpepper (2015) . URL: /~https://github.com/tmsalab/dina BugReports: /~https://github.com/tmsalab/dina/issues License: GPL (>= 2) -Imports: Rcpp -LinkingTo: Rcpp, RcppArmadillo -Depends: R (>= 3.0.1) +Imports: Rcpp (>= 0.12.10) +LinkingTo: Rcpp (>= 0.12.10), RcppArmadillo (>= 0.7.800) +Depends: R (>= 3.0.2) RoxygenNote: 6.0.1 diff --git a/cran-comments.md b/cran-comments.md index 3d5489a..c84d982 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -3,6 +3,15 @@ * ubuntu 12.04 (on travis-ci), R 3.4.0 * win-builder (devel and release) +## Feedback + +The previously submitted version of this package had a CRAN maintainer request +two requests. The first request dealt with the removal of latex style quotations +around the ``And'' in place of "And". Please note, the capitalization of the +"And" is important in the DINA model acronym and was left in place for this +reason. The second request was to remove a space between `doi:` and the identifier. +This was also taken care of. + ## R CMD check results 0 errors | 0 warnings | 1 note