Cannot use id param for query strings

[dbpolito]

I got a route with no param declared, and i'm using like this:

route('something', {type: 'a', id: 1});

• Current: /something?0=1
• Expected: something?type=a&id=1

Probably introduced by #143

[jakebathman]

Can anyone reproduce this? I'll give it a try this Friday if not, just to see if it's still a bug and if it is we'll get a fix in.

[JameL83]

I can reproduce this and i think its this function normalizeParams in routes.js, correct me if i am wrong.

normalizeParams(params) {
if (typeof params === 'undefined')
        return {};

    // If you passed in a string or integer, wrap it in an array
    params = typeof params !== 'object' ? [params] : params;

    // If the tags object contains an ID and there isn't an ID param in the
    // url template, they probably passed in a single model object and we should
    // wrap this in an array. This could be slightly dangerous and I want to find
    // a better solution for this rare case.

    if (params.hasOwnProperty('id') && this.template.indexOf('{id}') == -1) {
        params = [params.id];
    }

    this.numericParamIndices = Array.isArray(params);
    return Object.assign({}, params);
}

[JameL83]

Any progress on this?

[KuNman]

I confirm this behavior.

Debug result of route(url, {page: 1, id: 2}).
Get params are broken.

[hydrogennz]

@KuNman did the route you were building this for have an optional id param by chance?

i.e. Route::get("/check/{id?}")->name("check")

The issue I think is the check in normalizeParams needs to also check for optional ID params.

e.g.:

        if (
            params.hasOwnProperty('id') && this.template.indexOf('{id}') == -1
        ) {
            params = [params.id];
        }

needs to be:

        if (
            params.hasOwnProperty('id') &&
            (this.template.indexOf('{id}') == -1 && this.template.indexOf('{id?}') == -1)
        ) {
            params = [params.id];
        }

Edit:

Just realised that #263 actually solves the problem as above. This definitely seems to be the issue only thing now is to merge it in and mark this as resolved.