fix: incompatibility with newer transformers package (fixes #20) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…da#20) Signed-off-by: Stephen L. <LRQ3000@gmail.com>
|
@thammegowda If you are looking for a maintainer for this repo, please consider my application. I don't have much time to actively develop it, but I think it is apublic utility project, and I am a very experienced Python open-source developer and maintainer of lots of repositories, some of them extremely popular. It would be my honor to take care of the janitor duties such as checking, fixing and merging PRs, improving the packaging to the new pyproject.toml standard, answering questions, etc. Note that to make me a maintainer you will need to move this repo into an organization (that's free for opensource projects). Thank you very much for your awesome work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the fix proposed by @GOvEy1nw.
Also increases the minimum required version of transformers to ensure that we don't get the opposite issue (of people using older transformers version).
I considered supporting both the old and new transformers releases, but given the current transformers release is v4.46 and the minimum required version to fix this issue is v4.38, I think it's safe to support the newer releases only, as 4.38 is already quite old.
I did not edit the version, I let you do it.