Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable route_settings in default stage #78

Closed
honglus opened this issue Aug 29, 2022 · 4 comments
Closed

Enable route_settings in default stage #78

honglus opened this issue Aug 29, 2022 · 4 comments

Comments

@honglus
Copy link
Contributor

honglus commented Aug 29, 2022

Is your request related to a problem? Please describe.

route_settings are in main.tf but are commented out, Maybe it was due to a bug in AWS provider, But anyway I tested it worked with throttling_burst_limit and throttling_rate_limit with AWS v4.25.0
/~https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2/blob/master/main.tf#L92
Simply uncomment the block won't work with reason below.

Describe the solution you'd like.

route_settings will override default_settings, So even I just want to set throttling_rate_limit on route "POST /test", I have to set the remaining variables to use default_route_settings values, otherwise it will be AWS default value not default_route_settings value. e.g detailed_metrics_enabled will become false.
Enable route_settings and add only the route with at least one of the options:
data_trace_enabled, logging_level, throttling_burst_limit, throttling_rate_limit, detailed_metrics_enabled is not null
set the remaining variables to use use default_route_settings values

@honglus
Copy link
Contributor Author

honglus commented Sep 9, 2022

pull request #80

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 10, 2022
@honglus
Copy link
Contributor Author

honglus commented Oct 10, 2022

fixed by #80

@honglus honglus closed this as completed Oct 10, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant