Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] SinePositionalEncoding #115

Open
soran-ghaderi opened this issue Jun 1, 2024 · 0 comments
Open

[BUG] SinePositionalEncoding #115

soran-ghaderi opened this issue Jun 1, 2024 · 0 comments
Assignees
@soran-ghaderi
Labels
bug Something isn't working good first issue Good for newcomers tensorflow Related to Tensorflow

Comments

@soran-ghaderi
Copy link
Member

SinePositionalEncoding

Expected behavior
The sine positional encoding should combine the sine and cosine encoding using odd and even positions, but this implementation is concatenating them.
@soran-ghaderi soran-ghaderi added the bug Something isn't working label Jun 1, 2024
@soran-ghaderi soran-ghaderi self-assigned this Jun 1, 2024
@soran-ghaderi soran-ghaderi added good first issue Good for newcomers tensorflow Related to Tensorflow labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soran-ghaderi soran-ghaderi

Labels
bug Something isn't working good first issue Good for newcomers tensorflow Related to Tensorflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soran-ghaderi