Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline pgmq-rs ext client queue creation behaviour #127

Open
v0idpwn opened this issue Sep 27, 2023 · 3 comments
Open

Streamline pgmq-rs ext client queue creation behaviour #127

v0idpwn opened this issue Sep 27, 2023 · 3 comments

Comments

@v0idpwn
Copy link
Collaborator

v0idpwn commented Sep 27, 2023

Currently, create, create_partitioned, create_non_partitioned and create_unlogged return Result<Boolean, Error>, and claim to return false if the queue already existed, but create, create_non_partitioned and create_unlogged return true independent from the queue existing or not.

@v0idpwn
Copy link
Collaborator Author

v0idpwn commented Sep 27, 2023

The extension-less client returns Result<(), Error>, which is simpler and probably as useful, since the inforrmation about the queue being new or not is not that relevant.

@ChuckHend
Copy link
Member

Also a bug in pgmq-rs, should return False when queue already exists.

@ChuckHend
Copy link
Member

Also a bug in pgmq-rs, should return False when queue already exists.

decided to ignore this and return unit to be consistent with all create functions

@ChuckHend ChuckHend removed this from pgmq 1.0.0 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants