From 88c91bff713c82c8700499334ad5778e6ae7783b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 6 Apr 2023 14:50:56 +0200 Subject: [PATCH] src: disable concurrent sparkplug compilation It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: /~https://github.com/nodejs/node/issues/47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 --- src/node.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/node.cc b/src/node.cc index 7ceeab375829b7..ca89fc610230e6 100644 --- a/src/node.cc +++ b/src/node.cc @@ -790,6 +790,10 @@ static ExitCode InitializeNodeWithArgsInternal( // is security relevant, for Node it's less important. V8::SetFlagsFromString("--no-freeze-flags-after-init"); + // TODO(targos): Remove when /~https://github.com/nodejs/node/issues/47297 is + // fixed. + V8::SetFlagsFromString("--no-concurrent-sparkplug"); + #if defined(NODE_V8_OPTIONS) // Should come before the call to V8::SetFlagsFromCommandLine() // so the user can disable a flag --foo at run-time by passing