Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase session throughput #70

Closed
szmarczak opened this issue Apr 26, 2021 · 5 comments
Closed

Increase session throughput #70

szmarczak opened this issue Apr 26, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@szmarczak
Copy link
Owner

szmarczak commented Apr 26, 2021 •
edited
Loading

nodejs/node#31084
nodejs/node#31932

If we increase this by default, then sindresorhus/got#1520 can be closed.
@szmarczak szmarczak added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 26, 2021
@szmarczak szmarczak pinned this issue Apr 27, 2021
@szmarczak
Copy link
Owner Author

https://gist.github.com/szmarczak/4a764b3d00ae217267c9d79caafd4082

@szmarczak
Copy link
Owner Author

@kanongil @Rantoledo @CrucialDrew It's now possible to achieve the gain by setting the window on the session and the streams. See the above repro.

@szmarczak
Copy link
Owner Author

nodejs/node#38426

@szmarczak
Copy link
Owner Author

Fixed in 3ff05e9

@szmarczak szmarczak changed the title Increase session window throughput Increase session throughput Apr 27, 2021
@szmarczak
Copy link
Owner Author

I wonder what's the impact of maxFrameSize

@szmarczak szmarczak unpinned this issue May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szmarczak