Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/ts_strip): Handle ASI hazard in return statement #9882

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

magic-akari
Copy link
Member

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 04f6833

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review January 15, 2025 12:22
@magic-akari magic-akari requested a review from a team as a code owner January 15, 2025 12:22
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9882 will degrade performances by 4.56%

Comparing magic-akari:fix/issue-9878 (04f6833) with main (751a310)

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 192 untouched benchmarks
⁉️ 9 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9878 Change
es/full/minify/libraries/lodash 256.8 ms 246.8 ms +4.05%
es/full/minify/libraries/moment 130.1 ms 124.1 ms +4.9%
es/minifier/libs/jquery 167.2 ms 160.5 ms +4.17%
es/minifier/libs/moment 98.2 ms 102.9 ms -4.56%
⁉️ es/visitor/base-perf/boxing_boxed 3.3 µs N/A N/A
⁉️ es/visitor/base-perf/boxing_boxed_clone 2.4 µs N/A N/A
⁉️ es/visitor/base-perf/boxing_unboxed 3.5 µs N/A N/A
⁉️ es/visitor/base-perf/boxing_unboxed_clone 2.6 µs N/A N/A
⁉️ es/visitor/base-perf/fold_empty 327.3 µs N/A N/A
⁉️ es/visitor/base-perf/fold_noop_impl_all 327.5 µs N/A N/A
⁉️ es/visitor/base-perf/fold_noop_impl_vec 327.4 µs N/A N/A
⁉️ es/visitor/base-perf/module_clone 326.9 µs N/A N/A
⁉️ es/visitor/base-perf/visit_contains_this 47.2 µs N/A N/A

@kdy1 kdy1 added this to the Planned milestone Jan 15, 2025
@kdy1 kdy1 self-assigned this Jan 15, 2025
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 merged commit 121b5fe into swc-project:main Jan 15, 2025
168 checks passed
@bakkot
Copy link

bakkot commented Jan 15, 2025

This didn't address the whole issue: the same thing happens for throw and would presumably also happen for yield if it worked at all.

@kdy1 kdy1 modified the milestones: Planned, 1.10.8 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/wasm-typescript incorrect output for return followed by a type with a newline
3 participants