Skip to content

Latest commit

 

History

History
42 lines (29 loc) · 1.57 KB

DEVELOPING.md

File metadata and controls

42 lines (29 loc) · 1.57 KB

Contributing to Bring project within Svydovets Team

Important links

Branching strategy

In this repository we maintain one key development branch dev. In most cases it should be updated via the Pull Request. The main branch will contain only stable releases.

Creating a Pull Request

Branching naming convention

A branch name...

  • should start from the word "feature" or "bugfix" (according to the type of ticket you are working on)
  • then following ticket name from Trello (e.g. "BR-34")
  • optionally there may follow short description

Example

  • feature/BR-5/aplicationContextBaseStructure
  • bugfix/BR-23

Commits

  • In case you are working on the Trello ticket, please make sure that you always add its full number to every commit message
  • Please provide a descriptive messages
  • Use squash and rebase to avoid redundant commits

Definition of done

You are ready to create a PR for your ticket if the following criteria are met:

  • Local mvn verify is passing without the errors
  • Ticket`s acceptance criteria are met
  • Your code is covered by tests
  • Your code is covered by JavaDocs on the main methods