Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter-vercel doesn't redirect prerendered pages with incorrect trailing slash #8322

Closed
KevsRepos opened this issue Jan 3, 2023 · 3 comments
Labels
bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter

Comments

@KevsRepos
Copy link

Describe the bug

https://svelte.dev/blog/ loads without css, but https://svelte.dev/blog works fine. Same bug appears on all subroutes: https://svelte.dev/blog/whats-new-in-svelte-january-2023/ and so on...

Reproduction

I've just experienced it on the svelte.dev/blog site, but this looks like a kit specific error and not like a site specific error.

Logs

Loading module from “https://svelte.dev/blog/_app/immutable/start-e5c89509.js” was blocked because of a disallowed MIME type (“text/html”).

And the various css files couldnt load aswell.

System Info

System:
    OS: Linux 6.0 Pop!_OS 22.04 LTS
    CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
    Memory: 254.69 MB / 15.51 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 17.2.0 - ~/.nvm/versions/node/v17.2.0/bin/node
    Yarn: 1.22.15 - ~/.nvm/versions/node/v17.2.0/bin/yarn
    npm: 8.1.4 - ~/.nvm/versions/node/v17.2.0/bin/npm
  Browsers:
    Firefox: 108.0

Severity

annoyance

Additional Information

No response

@KevsRepos
Copy link
Author

Just realized I set annoyance because I only experienced it on the svelte.dev website, but I guess this is an actual dealbreaker if this bug would appear on my own websites. So its more like a "cant use Sveltekit"

@Rich-Harris Rich-Harris changed the title CSS doesnt load when route ends with a slash adapter-vercel doesn't redirect prerendered pages with incorrect trailing slash Jan 6, 2023
@Rich-Harris
Copy link
Member

This is an issue with adapter-vercel — the platform doesn't differentiate between /blog and /blog/ if blog.html is a prerendered file.

@Rich-Harris Rich-Harris added pkg:adapter-vercel Pertaining to the Vercel adapter bug Something isn't working labels Jan 6, 2023
@Rich-Harris
Copy link
Member

Looks like this was actually fixed by #8766 — closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Development

No branches or pull requests

2 participants