Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type support #8

Closed
wants to merge 1 commit into from
Closed

Add type support #8

wants to merge 1 commit into from

Conversation

xgwang-scienceos
Copy link

@xgwang-scienceos xgwang-scienceos commented Feb 5, 2025 •
edited
Loading

This change is to fix #4

Before the fix, we see import type error:
before

After the fix, we see error is gone:
after

Tests still pass:
tests

How does this change work?

  1. added a tsconfig.json file including ts, js and svelte files
  2. configured vite to use dts from vite-plugin-dts to generate types

@xgwang-scienceos
Copy link
Author

@marta-ko @olgatash Could you help taking a look at this PR? Thanks!

@xgwang-scienceos xgwang-scienceos mentioned this pull request Feb 5, 2025
Open
@xgwang-scienceos
Copy link
Author

Hi @Zwillinge, could you help taking a look at this PR? Thanks!

@Zwillinge
Copy link

Zwillinge commented Feb 20, 2025 •
edited
Loading

I'm not sure that we can incorporate this right now. As far as I can see, the issue does not block Grid from using. The generated types are not that useful (just default SvelteComponent-s). For future versions we can consider full-scale typescript support, but we need to work it out for the whole SVAR framework

@xgwang-scienceos
Copy link
Author

I'm not sure that we can incorporate this right now. As far as I can see, the issue does not block Grid from using. The generated types are not that useful (just default SvelteComponent-s). For future versions we can consider full-scale typescript support, but we need to work it out for the whole SVAR framework

That makes sense! What is the current status for full-scale ts support? Is it already started? If not && you need extra set of hands, I'm willing to help

@Zwillinge Zwillinge closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cant import Grid
3 participants
@xgwang-scienceos @Zwillinge @wxgisu