Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking]: Update the Viewport and Background Addon #30678

Open
9 tasks
valentinpalkovic opened this issue Feb 26, 2025 · 0 comments
Open
9 tasks

[Tracking]: Update the Viewport and Background Addon #30678

valentinpalkovic opened this issue Feb 26, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Feb 26, 2025

This milestone aims to finalize the schema change for the viewport global, remove feature flags, and improve viewport configuration options in Storybook to align with best practices and Chromatic compatibility.

Items:

1. Remove feature flags committing to the API

  • Identify all references to viewport feature flags in the Storybook codebase
    • Remove feature flags from configuration and API references
    • Ensure viewport schema is now the default, without a feature toggle
    • Ensure background schema is now the default, without a feature toggle

2. Update Viewport Global Schema to Support the Legacy Format

  • Ensure Storybook 9 supports both viewport: 'iphone13' and viewport: { value: 'iphone13', isRotated: true }

3. Update Background Global Schema to Support the Legacy Format

  • Ensure Storybook 9 supports both background: 'red' and background: { value: 'red' }

4. Documentation and Migration Guide

  • Update documentation to reflect new viewport behavior
    • Provide migration notes for users transitioning from Storybook 8.x
    • Ensure API documentation clearly explains all viewport configuration options
@valentinpalkovic valentinpalkovic changed the title [Bug]: - [Tracking]: Update the Viewport Addon Feb 26, 2025
@valentinpalkovic valentinpalkovic added this to the 9.0 milestone Feb 26, 2025
@valentinpalkovic valentinpalkovic changed the title [Tracking]: Update the Viewport Addon [Tracking]: Update the Viewport and Background Addon Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants