Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declaration file resolution with "Bundler" moduleResolution specified in tsconfig.json #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Roman3349
Copy link

Fixes declaration file resolution with "Bundler" moduleResolution specified in tsconfig.json.

Motivation and Context

Fixes: stoplightio/json-schema-viewer#267.

Description

Fixes property ordering in exports property in package.json (see https://nodejs.org/api/packages.html#conditional-exports) - types should be first, import the second and require last. And also fixes invalid path (located in src/) for typing property.

How Has This Been Tested?

It was tested by building this package and testing it on /~https://github.com/stoplightio/json-schema-viewer/ which is currently affected.

Types of changes

See Description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find a declaration file for module '@stoplight/json-schema-viewer' with moduleResolution "Bundler"
1 participant