Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebAuthn Test Objects Class Names #16604

Open
5 tasks
jzheaux opened this issue Feb 14, 2025 · 2 comments
Open
5 tasks

Update WebAuthn Test Objects Class Names #16604

jzheaux opened this issue Feb 14, 2025 · 2 comments
Labels
status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 14, 2025 •
edited
Loading

By convention, Spring Security test objects are named Test{Object}s, as in TestAuthentications or TestKeys.

It would be nice to rename the WebAuthn test objects like TestAuthenticatorAttestationResponse to TestAuthenticatorAttestationResponses.

As an exception, I think we should leave classes that are already pluralized as TestPublicKeyCredentialCreationOptions since TestPublicKeyCredentialCreationOptionses is a little tricky to say.

I believe the following is a comprehensive list of the classes to change:

  • TestAuthenticatorAttestationResponse
  • TestCredentialRecord
  • TestPublicKeyCredential
  • TestPublicKeyCredentialUserEntity
  • TestPublicKeyCredentialRpEntity
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement status: first-timers-only An issue that can only be worked on by brand new contributors and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 14, 2025
@kiruthiga1793
Copy link

Hi @jzheaux , I'm interested. Can you please assign me?

@vasanth-79
Copy link

Hi @jzheaux
I'm interested. Could you please assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jzheaux @kiruthiga1793 @vasanth-79