Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release a new code generator version for NPM packages with Node.js 18+ major versions #1495

Open
libre-man opened this issue Jan 7, 2025 · 1 comment
Assignees
Labels
pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@libre-man
Copy link
Contributor

After dropping Node 16, all Smithy helper packages were upgraded to a major version. However, the generated code when using version 0.25.0 still relies on older versions of these packages.

This mismatch causes issues due to AWS SDK peer dependencies, resulting in errors like:

The inferred type of 'MyCommand' cannot be named without a reference to '@smithy/smithy-client/node_modules/@smithy/middleware-endpoint'. This is likely not portable. A type annotation is necessary.

The problem can be resolved by adding the following dependencies to the generated package.json:

{
    "@smithy/protocol-http": "^4.1.8",
    "@smithy/middleware-endpoint": "^3.2.3"
}

However, it would be much more convenient and robust if the release version of smithy-typescript was release, so we can generate code that uses the latest versions of the Smithy helper packages directly.

@kuhe kuhe changed the title Please release a new version Please release a new code generator version for NPM packages with Node.js 18+ major versions Jan 8, 2025
@mcintoac-aws
Copy link

Also facing the same issue. This has become a blocker for us since the @AWS-SDK namespace has been updated to 3.723.0. The sub-dependencies here include the outdated @smithy/core and @smithy/types versions.

Since the codegen generated packages are out of sync with the more recent versions, this creates failures when trying to build our packages.

Any updates on a new codegen version which will use the new releases of the @AWS-SDK (^3.723.0), @smithy/core (^3.0.0), and @smithy/types (^4.0.0)?

@kuhe kuhe added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

No branches or pull requests

4 participants