Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on protocol page pointing to endpoint that does not respond #14

Open
AJ-Ianozi opened this issue May 19, 2023 · 2 comments
Open

Documentation on protocol page pointing to endpoint that does not respond #14

AJ-Ianozi opened this issue May 19, 2023 · 2 comments

Comments

@AJ-Ianozi
Copy link

Hello,

There are some discrepancies between the Protocol Page and the Developer Guide in terms of the demo endpoints.

For example, the protocol lists an example such as:
Request:
curl https://bridge.simplefin.org/simplefin/info
Response:

{
    "versions": ["1.0-draft"],
}

However, doing that doesn't return anything. But this works:
curl https://beta-bridge.simplefin.org/simplefin/info
Which returns:

{"versions":["1.0-draft"]}

Also the QuickStart mentions the sample token of aHR0cHM6Ly9icmlkZ2Uuc2ltcGxlZmluLm9yZy9zaW1wbGVmaW4vY2xhaW0vZGVtbw== which decodes to https://bridge.simplefin.org/simplefin/claim/demo (and in theory should return https://user123:pass456@bridge.simplefin.org/simplefin via curl), but it doesn't behave like so. Instead, calling curl returns a redirect to beta-bridge.simplefin.org.

Likewise, calling curl "https://user123:pass456@bridge.simplefin.org/simplefin/accounts" also returns no data due to this redirect.

On the other hand, if I decode aHR0cHM6Ly9iZXRhLWJyaWRnZS5zaW1wbGVmaW4ub3JnL3NpbXBsZWZpbi9jbGFpbS9ERU1P into https://beta-bridge.simplefin.org/simplefin/claim/DEMO, provided by the Developer's Guide, and then curl -X POST "https://beta-bridge.simplefin.org/simplefin/claim/DEMO", I successfully retrieve https://demo:demo@beta-bridge.simplefin.org/simplefin and then I'm able to follow the quick start with ACCESS_URL="https://demo:demo@beta-bridge.simplefin.org/simplefin"

I guess the question is, is it intentional to no longer hold the simplefin bridge server at bridge.simplefin.org? If so, should documentation be updated to point to beta-bridge.simplefin.org?

Kind regards,
AJ.
@iffy
Copy link
Member

iffy commented Jun 12, 2023

If you add the -L flag to your curl commands, does everything work? The intent is to keep things at bridge. but while in beta to have that redirect to beta-bridge. transparently.

@AJ-Ianozi
Copy link
Author

Hey, sorry for the late reply. This is what I get on both Linux and MacOS when I execute the command curl -L https://bridge.simplefin.org/simplefin/info or curl -L "https://user123:pass456@bridge.simplefin.org/simplefin/accounts":

<!doctype html>
<html lang="en">
  <head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="Description" content="The SimpleFIN Bridge lets you securely share your financial transaction data with apps.">
    <title>Connect to your bank - SimpleFIN Bridge</title>
    <link rel="stylesheet" href="/static/wing.css" />
    <link rel="stylesheet" href="/static/style.css" />
    <link rel="icon" href="/static/favicon.png" type="image/png" /> 
  </head>
  <body>
    <section class="container main-wrapper">
      
      <section class="main-document">
      <header class="nav left">
        <div class="nav-item logo-holder">
          <img src="/static/logo.svg" class="logo" alt="SimpleFIN Logo"/>
          SimpleFIN Bridge
        </div>
        <div class="nav-item">
          <a href="/">Home</a>
        </div>
        <div class="nav-item">
          <a href="/auth/login">Sign in</a>
        </div>
      </header>
      
      <section class="messages">

      </section>
      
      <section class="main">
        
        <div class="side-by-side">
  <div style="flex-grow: 2;">
    <h1>Connect to your bank</h1>
    <p>
      The SimpleFIN Bridge lets you securely share your financial transaction data with apps.  Connect up to 25 institutions and 25 apps for either:
    </p>
    <ul>
      <li>$1.50 per month, or</li>
      <li>$15.00 per year</li>
    </ul>
    <a class="button" href="/auth/login">Get started</a>
  </div>
  <div class="left-border" style="flex-grow: 1;">
    <h4 style="margin-top: 0;">Developers</h4>
    <p>
      Easily integrate financial transactions into your app. Check out the <a href="/info/developers">Developer guide</a> to learn more.
    </p>
  </div>
</div>
      </section>

    </section>

    <footer>
      <div class="footer-nav">
        <a href="/search-institutions">Supported institutions</a>
        <a href="/info/developers">Developer guide</a>
        <a href="/info/mission">Our mission</a>
        <a href="/info/terms">Terms of Use</a>
        <a href="/info/privacy">Privacy</a>
        <a href="/info/security">Security</a>
        <a href="/info/contact">Contact us</a>
      </div>
      <p class="copyright">Copyright &copy; SimpleFIN</p>
    </footer>
    </section>
  </body>
</html>```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iffy @AJ-Ianozi