Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML showing in inline preview #39

Closed
emteknetnz opened this issue Jun 12, 2023 · 4 comments
Closed

HTML showing in inline preview #39

emteknetnz opened this issue Jun 12, 2023 · 4 comments
Assignees
@GuySartorelli
Labels
affects/v5 impact/medium type/bug Something isn't working

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jun 12, 2023 •
edited by sabina-talipova
Loading

Happens in CMS 5, doesn't happen in CMS 4

image

Replicate steps:

  • Create a new file block
  • Upload a new image
  • Save the page

PRs
@GuySartorelli
Copy link
Member

This is happening because getSummary() is actually being used now, where in CMS 4 it wasn't. The summary should just be a plain-text summary.

This was referenced Jul 10, 2023
Merged
Merged
@sabina-talipova
Copy link
Contributor

sabina-talipova commented Jul 10, 2023 •
edited
Loading

We should probably remove the FileBlock::getSummaryThumbnail method and SummaryThumbnail.ss template file in the future as they are no longer needed.
Update: If you check Summary Component in silverstripe-elemental you will see that there are no ways how to set HTML Elements and probably any HTML will be redundant there.

@sabina-talipova sabina-talipova removed their assignment Jul 10, 2023
This was referenced Jul 11, 2023
Merged
Merged
@GuySartorelli
Copy link
Member

Bug fixes tagged on fileblock and bannerblock respectively as 3.0.2

@GuySartorelli
Copy link
Member

All PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v5 impact/medium type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emteknetnz @GuySartorelli @sabina-talipova