Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation for adding new Providers #116

Closed
serpro69 opened this issue Dec 3, 2021 · 0 comments · Fixed by #130
Closed

Better documentation for adding new Providers #116

serpro69 opened this issue Dec 3, 2021 · 0 comments · Fixed by #130
Assignees
@serpro69
Labels
docs 📃 Documentation-related issues enhancement 🚀 New feature or request

Comments

@serpro69
Copy link
Owner

serpro69 commented Dec 3, 2021 •
edited
Loading

Need to have better documentation on what are all the things that need to be considered/added/changed (including tests) when adding a new AbstractFakeDataProvider implementation

This struck me when reviewing #115 . I can imagine it could be hard/time consuming to piece all the little things together without proper documentation for first-time contributors.
@serpro69 serpro69 added enhancement 🚀 New feature or request docs 📃 Documentation-related issues labels Dec 3, 2021
@serpro69 serpro69 self-assigned this Dec 3, 2021
@serpro69 serpro69 linked a pull request May 19, 2022 that will close this issue
Document how to add new data providers in contributing guidelines #130
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serpro69 serpro69

Labels
docs 📃 Documentation-related issues enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document how to add new data providers in contributing guidelines serpro69/kotlin-faker
1 participant
@serpro69