Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in generated deps.edn #79

Open
wesleyhall opened this issue Mar 19, 2019 · 0 comments
Open

Errors in generated deps.edn #79

wesleyhall opened this issue Mar 19, 2019 · 0 comments

Comments

@wesleyhall
Copy link

Upon generating a project, the deps.edn file has some problems. I am only using the reagent version, but the template refers to version 0.7.1 of reagent, which does not seem to exist. The project.clj refers to 0.7.0. Changing the generated deps.edn seemed to resolve this.

Next problem was that "oops" is missing. I added binaryage/oops {:mvn/version "0.5.8"} to the deps and this problem too was resolved.

I was about to submit a PR here. Simple fixes of course, but I realise that I am only running the reagent version and similar problems might exist in other variants.

I'm happy to take a look at each of them and fix any problems in the deps.edn but since I am running Java 11, I get the deadly xml-lib problem with figwheel. Upgrading usually solves this but some of the figwheel internals have changed so it's not so simple.

I've found a quick guide on copying the figwheel bridge from re-natal that supports the new structure, but it might take me some time to set up so I can test properly. Should anybody want to dive in with a PR in the short term, they can steal my thunder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant