From 5b858465f2709929a8a78db275a6dc88bb18b5a3 Mon Sep 17 00:00:00 2001 From: "Robert H. Engelhardt" <1584973+rheone@users.noreply.github.com> Date: Sun, 10 Nov 2019 18:26:08 -0700 Subject: [PATCH] Update pull_request_template.md (#40) closes #36 --- .github/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f14ab26..34e24ca 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,14 +6,14 @@ Hello, and welcome! Thanks you for your contribution to **Gulliver**. - [ ] Does it fix a bug? - [ ] Does it add new functionality? -1. Assuming there is a code change in this contribution +2. Assuming there is a code change in this contribution - [ ] Have you included unit test(s) to verify the change? - [ ] Do all pre-existing unit tests pass as expected? - [ ] Does the change break existing functionality, if so have you explained why doing so is necessary? - [ ] Have you listed the possible side-effects or negative impacts of the code change. -1. Put `closes #XXXX` in your comment, where XXXX is the the issue that your PR fixes. -1. Provide any other information that pertinent to the PR you're making. -1. Click "Create pull request". +3. Put `closes #XXXX` in your comment, where XXXX is the the issue that your PR fixes. +4. Provide any other information that pertinent to the PR you're making. +5. Click "Create pull request". Thanks again, we'll review your PR and and act accordingly.