Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random small bug fixes #171

Open
tiiavalt opened this issue Apr 1, 2021 · 0 comments · Fixed by #172
Open

Random small bug fixes #171

tiiavalt opened this issue Apr 1, 2021 · 0 comments · Fixed by #172
Assignees
Labels
bug Something isn't working

Comments

@tiiavalt
Copy link
Contributor

tiiavalt commented Apr 1, 2021

Describe the bug
Let's find and fix small bugs around the project, e.g. accessibility, style and other bugs that are too small to fix one by one in their own issues.

--
The result

Added:

  • aria-labels for offsetButtons
  • default case for breadcrumbs’ switch case

Deleted:

  • file: KeywordAnalysisTable.styles.js

Fixed:

  • checkbox container’s border color
  • front page’s icons’ sizes and margins
  • footer’s height and add some margin, and fixed the logo’s accessibility
  • breadcrumbs’ aria-labels
  • table’s scroll buttons’ aria-label
  • pie charts’ styles and header level
  • tabs’ active link’s hover
  • accordion’s first th’s width
  • table th’s margin

Removed:

  • redundant titles
  • duplicate ‘main’
  • redundant class ‘underline’
  • redundant ‘!important’s
  • redundant text-decoration from links, because it’s already a default style
  • redundant aria-label and content and hid duplicate content from screen reader

Other:

  • replaced pixels with css variables
  • external links open now in a new tab
@tiiavalt tiiavalt added the bug Something isn't working label Apr 1, 2021
@tiiavalt tiiavalt self-assigned this Apr 1, 2021
@tiiavalt tiiavalt linked a pull request Apr 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant