Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review single line where clauses diffs #197

Closed
calebcartwright opened this issue Oct 22, 2024 · 1 comment
Closed

Review single line where clauses diffs #197

calebcartwright opened this issue Oct 22, 2024 · 1 comment

Comments

@calebcartwright
Copy link
Member

rust-lang/rust#119515 modified the Style Guide for 2024 to switch to single line formatting for type aliases and body-less functions with rules that included some new "short" thresholds.

This has been implemented in rustfmt with some suggested values for those "short" thresholds, with some examples shown in https://rust-lang.zulipchat.com/#narrow/channel/346005-t-style/topic/single.20line.20where.20clauses

Similar to exercises we've done with other 2024 changes, I'd like to review the formatting results under the new rules and thresholds to (a) confirm it's what the team wants and (b) see if there's any t-style input on those "short" thresholds

(sidebar but I will add that there was a comment from outside the team that expressed a dislike for the single line functions when the function had a return type)

@calebcartwright
Copy link
Member Author

This issue has served its purpose, topic was discussed and resolved in the 2024-10-23 t-style meeting. Closing accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant