Work around invalid spans in imported FileMaps #23489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 90b8b4d p=1 |
|
Nice! |
|
⌛ Testing commit 90b8b4d with merge a8379a4... |
|
💔 Test failed - auto-mac-64-opt |
|
💔 indeed. I'll fix this when I come home after work today. On March 19, 2015 1:17:12 AM CET, bors notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
michaelwoerister
force-pushed
the
span-artihmetic-overflow-bug
branch
from
90b8b4d to
1ea971f
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 20, 2015
…erflow-bug, r=alexcrichton This should solve issues rust-lang#23115, rust-lang#23469, and rust-lang#23407. As the title says, this is just a workaround. The underlying problem is that macro expansion can produce invalid spans. I've opened issue rust-lang#23480 so we don't forget about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve issues #23115, #23469, and #23407.
As the title says, this is just a workaround. The underlying problem is that macro expansion can produce invalid spans. I've opened issue #23480 so we don't forget about that.