NLL: turn on borrowck=migrate by default on 2015 edition #57804
Closed
Description
As a sub-step towards having NLL produce hard errors (rather than downgrading its errors to warnings) and removing the AST-borrowck code, we want to turn on the NLL migration mode (introduced with the 2018 edition) so that it operates in all editions. Namely, we want to introduce the -Z borrowck=migrate
(and associated -Z two-phase-borrows
) on the 2015 edition.
This is a subtask of #43234
On Zulip, @matthewjasper composed the following interesting table summarizing the open issues related to this, which I am transcribing here (with some light editing to replace pronouns with names).
all blocking issues are marked either P-High or NLL-Sound of those issues the current state is:
Issue number | Blocks migrate | Assigned To | Notes |
---|---|---|---|
@matthewjasper / @nikomatsakis | |||
#56254 | Yes | @matthewjasper | #58739 |
@matthewjasper | |||
@matthewjasper | |||
@matthewjasper | |||
#58178 | @matthewjasper | Good enough after #58347 | |
#54105 | No | @nikomatsakis | Needs to be fixed, but not clear what, if any, code this affects |
#54940 | No | @nikomatsakis | Obscure, no easy fix |
#46901 | No | @pnkfelix | need some idea what we're allowing for 2 phase borrows; (note #56254 above) |
@matthewjasper | |||
#56993 | No | @nikomatsakis | Just a test issue now |
#57374 | No | @lqd / @nikomatsakis | Not an issue in migrate mode |