-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android: stdlib stack overflow handlers are not installed #124823
Comments
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
May 6, 2024
saethlin
added
O-android
Operating system: Android
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
May 6, 2024
maurer
added a commit
to maurer/rust
that referenced
this issue
May 7, 2024
Stack probes are working correctly, but the SIGSEGV handler is not registered, so the expected message doesn't appear after running the test. Disable these to enable an aarch64-android runner. Re-enablement is tracked at rust-lang#124823
Semi-duplicate of #25872, though this issue is more detailed. |
maurer
added a commit
to maurer/rust
that referenced
this issue
May 18, 2024
Stack probes are working correctly, but the SIGSEGV handler is not registered, so the expected message doesn't appear after running the test. Disable these to enable an aarch64-android runner. Re-enablement is tracked at rust-lang#124823
maurer
added a commit
to maurer/rust
that referenced
this issue
Jul 10, 2024
Stack probes are working correctly, but the SIGSEGV handler is not registered, so the expected message doesn't appear after running the test. Disable these to enable an aarch64-android runner. Re-enablement is tracked at rust-lang#124823
maurer
added a commit
to maurer/rust
that referenced
this issue
Jul 18, 2024
Stack probes are working correctly, but the SIGSEGV handler is not registered, so the expected message doesn't appear after running the test. Disable these to enable an aarch64-android runner. Re-enablement is tracked at rust-lang#124823
maurer
added a commit
to maurer/rust
that referenced
this issue
Jul 19, 2024
Stack probes are working correctly, but the SIGSEGV handler is not registered, so the expected message doesn't appear after running the test. Disable these to enable an aarch64-android runner. Re-enablement is tracked at rust-lang#124823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When updating the CI to newer NDK/APIs, I enabled
aarch64-linux-android
testing, and found thattests/ui/abi/stack-probes.rs
was failing. Luckily, the stack probes themselves are working (the expected SIGSEGV is being triggered), but as the signal handler is not installed, the test fails and the user wouldn't receive a helpful error + backtrace in the real world.The registration is currently in an odd state where the implementation is enabled for Linux but not Android, and yet contains Android-specific cfgs inside.
Enabling it (by adding
"android"
to both themod
cfg blocks) works onaarch64
, but onarm
, it fails becausegetauxval
is missing fromlibc
.The route to fixing this:
getauxval
declaration to libc android 32-bit (it's already in 64-bit). The original argument for not including it is that it was added in Android API 18. Since we're bumping to 21+ as the minimum API, that should not be an issue.android
to the registration blockignore-android
I'm about to add fromtests/ui/abi/stack-probes.rs
andtests/ui/abi/stack-probes-lto.rs
and check that they still work.cc @chriswailes Perhaps you'd like to take this one?
The text was updated successfully, but these errors were encountered: