-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to support volume mounts outside user $HOME #107
Comments
Not all the non-home directories have the use case of being workspace directories. Users mostly want to work in their customized non-home directories instead of system directories. Also not all of them can be mounted to VM in Lima. For example, if Finch passes “/” as the mount point to Lima, it will return error.
So I’d like a feature that makes non-home directories a field in Finch config. An example yaml will be:
|
Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: #107 *Description of changes:* Doc *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: #107 *Description of changes:* add config to support additional directories according to the doc added in #123 *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
…inch#123) Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: runfinch#107 *Description of changes:* Doc *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
Signed-off-by: Ziwen Ning <ningziwe@amazon.com> Issue #, if available: runfinch#107 *Description of changes:* add config to support additional directories according to the doc added in runfinch#123 *Testing done:* - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
What is the problem you're trying to solve?.
Currently, finch containers can only access resources inside user's home directory. I think there should be more flexibility in mount locations exposed by the virtual machine.
Describe the feature you'd like
Allow users to configure additional mount locations during VM start. These locations will be accessible to containers through commands such as
finch run
orfinch cp
.Additional context
Adding an option to configure new mount locations in
${HOME}/.finch/finch.yaml
seems like a good approach. And perhaps through a command line flag, for eg:The text was updated successfully, but these errors were encountered: