From 8ee5763aa36b3633a931bbe848aa956650e515a2 Mon Sep 17 00:00:00 2001 From: Ziwen Ning Date: Fri, 13 Jan 2023 10:52:55 -0800 Subject: [PATCH] test: remove rosetta from installer test (#149) Signed-off-by: Ziwen Ning Issue #, if available: /~https://github.com/runfinch/finch/issues/105 *Description of changes:* Remove Rosetta from installer test as it is fixed in installer *Testing done:* Tested with the latest installer - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning --- .github/workflows/release-installer.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/release-installer.yaml b/.github/workflows/release-installer.yaml index 02ddfd8a6..b4ced72f6 100644 --- a/.github/workflows/release-installer.yaml +++ b/.github/workflows/release-installer.yaml @@ -57,11 +57,7 @@ jobs: run: | aws s3 cp s3://${{ secrets.INSTALLER_PRIVATE_BUCKET_NAME }}/Finch-${GITHUB_REF_NAME}-aarch64.pkg Finch-${GITHUB_REF_NAME}-aarch64.pkg - name: Silently install - # Rosetta is only needed in arm64. Currently the installer command will fail to install without Rosetta. - # TODO: Remove Rosetta command when the installer is fixed. (/~https://github.com/runfinch/finch/issues/105) - run: | - echo 'A' | sudo softwareupdate --install-rosetta - sudo installer -pkg Finch-${GITHUB_REF_NAME}-aarch64.pkg -target / + run: sudo installer -pkg Finch-${GITHUB_REF_NAME}-aarch64.pkg -target / - name: Run e2e tests run: INSTALLED=true make test-e2e - name: Silently uninstall