Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests with minimum RuboCop version #112

Closed
marcandre opened this issue May 21, 2020 · 3 comments
Closed

Tests with minimum RuboCop version #112

marcandre opened this issue May 21, 2020 · 3 comments
Assignees
@koic

Comments

@marcandre
Copy link
Contributor

marcandre commented May 21, 2020 •
edited
Loading

The minimum version of RuboCop needs to be bumped (to at least 0.82), and more importantly CI needs to test with whatever the minimum version of RuboCop is, as well as with master.
@marcandre marcandre mentioned this issue May 21, 2020
Closed
@koic
Copy link
Member

koic commented May 22, 2020

The next released version as bugfix version 1.6.1, so supported RuboCop core version remains unchanged (#111 will be fixed with the old API).
RuboCop Performance 1.7 will drop some older RuboCop support versions (and using new API).

Anyway, supported RuboCop core versions should be included in the CI matrix. I will take this later. Thank you for investigating and suggestion!

koic added a commit to koic/rubocop-performance that referenced this issue May 22, 2020
@koic
Specify testing context of Ruby 2.7 for Performance/BindCall
e3baf71 
This PR prepares for rubocop#112 and makes the `rake spec` successful
with RuboCop 0.71, which is supported by RuboCop Performance 1.6.

This is a workaround until the CI is ready for RuboCop Performance 1.7.
RuboCop Performance 1.7 will drop some older RuboCop support versions.
@koic koic mentioned this issue May 22, 2020
Merged
8 tasks
koic added a commit to koic/rubocop-performance that referenced this issue May 22, 2020
@koic
Specify testing context of Ruby 2.7 for Performance/BindCall
e1c67e7 
This PR prepares for rubocop#112 and makes the `rake spec` successful
with RuboCop 0.71, which is supported by RuboCop Performance 1.6.

This is a workaround until the CI is ready for RuboCop Performance 1.7.
RuboCop Performance 1.7 will drop some older RuboCop support versions.
@pirj
Copy link
Member

pirj commented Jun 8, 2020

We had this idea in rubocop-rspec and dropped it for one reason - with RuboCop 1.0 on the horizon and its conservative policy of breaking changes, it should not be a problem, we don't expect breakages for any of the versions satisfying rubocop ~> 1.0.

@koic
Copy link
Member

koic commented Apr 22, 2021

#235 and 3a7024e close this issue because it implements versioning ('>= 1.y', '< 2.0') similar to @pirj's opinion. Thank you.

@koic koic closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koic koic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pirj @koic @marcandre