Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.2 signal forwarder doesn't support --pidns #129

Closed
AkihiroSuda opened this issue Mar 15, 2020 · 2 comments · Fixed by #210
Closed

v0.9.2 signal forwarder doesn't support --pidns #129

AkihiroSuda opened this issue Mar 15, 2020 · 2 comments · Fixed by #210
Labels
bug Something isn't working help wanted Extra attention is needed priority/high

Comments

@AkihiroSuda
Copy link
Member

#127 doesn't support --pidns.

Without --pidns (works as expected)

$ dockerd-rootless.sh --experimental
...
INFO[2020-03-15T11:02:42.263959577+09:00] API listen on /run/user/1001/docker.sock     
^CINFO[2020-03-15T11:02:43.493624366+09:00] Processing signal 'interrupt'                
INFO[2020-03-15T11:02:43.494655209+09:00] Processing signal 'interrupt'                
INFO[2020-03-15T11:02:43.495386457+09:00] stopping event stream following graceful shutdown  error="<nil>" module=libcontainerd namespace=moby
INFO[2020-03-15T11:02:43.495546067+09:00] Daemon shutdown complete                     
INFO[2020-03-15T11:02:43.495566660+09:00] stopping event stream following graceful shutdown  error="context canceled" module=libcontainerd namespace=plugins.moby
INFO[2020-03-15T11:02:43.495587614+09:00] stopping healthcheck following graceful shutdown  module=libcontainerd
INFO[2020-03-15T11:02:43.495986508+09:00] Processing signal 'interrupt'
$ echo $?
0

With --pidns (unexpected failure)

$ DOCKERD_ROOTLESS_ROOTLESSKIT_FLAGS=--pidns dockerd-rootless.sh --experimental
...
INFO[2020-03-15T13:28:53.859447390+09:00] API listen on /run/user/1001/docker.sock     
^CINFO[2020-03-15T13:28:54.892282069+09:00] Processing signal 'interrupt'                
INFO[2020-03-15T13:28:54.892349636+09:00] Processing signal 'interrupt'                
INFO[2020-03-15T13:28:54.895970152+09:00] stopping event stream following graceful shutdown  error="<nil>" module=libcontainerd namespace=moby
INFO[2020-03-15T13:28:54.898414592+09:00] Daemon shutdown complete                     
INFO[2020-03-15T13:28:54.898938906+09:00] stopping event stream following graceful shutdown  error="context canceled" module=libcontainerd namespace=plugins.moby
INFO[2020-03-15T13:28:54.899736172+09:00] stopping healthcheck following graceful shutdown  module=libcontainerd
[rootlesskit:child ] error: command [/usr/local/bin/dockerd-rootless.sh --experimental] exited: waitid: no child processes
[rootlesskit:parent] error: child exited: exit status 1
$ echo $?
1
@AkihiroSuda
Copy link
Member Author

@ibuildthecloud Any chance to take a look?

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jul 28, 2020

Also:

$ rootlesskit --pidns /bin/true
[rootlesskit:child ] error: command [/bin/true] exited: waitid: no child processes
[rootlesskit:parent] error: child exited: exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant