Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: tsc --skipLibCheck fails on React 17 #10621

Closed
brophdawg11 opened this issue Jun 20, 2023 · 3 comments
Closed

[Bug]: tsc --skipLibCheck fails on React 17 #10621

brophdawg11 opened this issue Jun 20, 2023 · 3 comments
Labels
bug

Comments

@brophdawg11
Copy link
Contributor

brophdawg11 commented Jun 20, 2023 •
edited
Loading

What version of React Router are you using?

6.13.0

Steps to Reproduce

In a Typescript React 17 app using react-router-dom@6.13.0 running TSC and including node_modules will fail:

npx tsc --skipLibCheck false

New issue created from #10566 (comment).
@brophdawg11 brophdawg11 changed the title [Bug]: tsc6.1`3.0 --skipLibCheck fails on React 17 [Bug]: tsc --skipLibCheck fails on React 17 Jun 20, 2023
@brophdawg11 brophdawg11 mentioned this issue Jun 20, 2023
Merged
@brophdawg11 brophdawg11 added the awaiting release This issue have been fixed and will be released soon label Jun 20, 2023
@brophdawg11
Copy link
Contributor Author

This is fixed by #10622 and will be available in the next release

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11 brophdawg11 removed the awaiting release This issue have been fixed and will be released soon label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brophdawg11