From 0871cffe678b1e46257f148cd4268e107103f78c Mon Sep 17 00:00:00 2001 From: Ivo Jimenez Date: Thu, 12 Sep 2024 17:34:57 -0400 Subject: [PATCH 1/2] dt: remove warning about unimplemented function Signed-off-by: Ivo Jimenez (cherry picked from commit f4c27fd0856824bb7c1d2062178404d412787cfc) --- tests/rptest/services/rpk_producer.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/rptest/services/rpk_producer.py b/tests/rptest/services/rpk_producer.py index bad9861550ed2..9c5ea6d028765 100644 --- a/tests/rptest/services/rpk_producer.py +++ b/tests/rptest/services/rpk_producer.py @@ -90,3 +90,6 @@ def output_line_count(self): def stop_node(self, node): self._stopping.set() node.account.kill_process("rpk", clean_shutdown=False) + + def clean_node(self, node): + pass From 86409ac1ea764e4f8e0dbb9412faaf940ed1f4db Mon Sep 17 00:00:00 2001 From: Ivo Jimenez Date: Fri, 13 Sep 2024 21:44:31 -0400 Subject: [PATCH 2/2] dt/rpk: remove logging of exception Instead of logging, assume caller will catch/log the exception to avoid polluting the log when an exception is ignored. Signed-off-by: Ivo Jimenez (cherry picked from commit 9bce021939bd83d99d1480106c1a027d262f1719) --- tests/rptest/clients/rpk.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/rptest/clients/rpk.py b/tests/rptest/clients/rpk.py index b5b0c5bfb1286..75ef8633ecacd 100644 --- a/tests/rptest/clients/rpk.py +++ b/tests/rptest/clients/rpk.py @@ -1135,7 +1135,6 @@ def _execute(self, cmd, stdin=None, timeout=None, log_cmd=True, env=None): self._redpanda.logger.debug(f'\n{output}') if p.returncode: - self._redpanda.logger.error(stderror) raise RpkException( 'command %s returned %d, output: %s' % (' '.join(cmd) if log_cmd else '[redacted]', p.returncode,