Population of workspace github preferences using Keycloak & GitHub API

[ibuziuk]

Need to implement the population of workspace github preferences using Keycloak & GitHub API.
Currently, che-starter uses wsmaster API for setting preferences, so first need to have mechanism in place for setting preferences per user or per workspace

[gorkem]

@benoitf can you confirm that wsmaster API is in fact multi-tenant ready?

[benoitf]

yes preferences API is multi tenant ready but there is no implementation of users/filters that manage different users in Che
Codenvy is using the same wsmaster API preferences implementation but has filters that assign current user

For example the token validator implementation in che is always providing "che"
/~https://github.com/eclipse/che/blob/8e5967613daddac84d9e3ea0ef47d53d08dbd11e/wsmaster/wsmaster-local/src/main/java/org/eclipse/che/api/local/DummyTokenValidator.java

while in codenvy there is
/~https://github.com/codenvy/codenvy/blob/ca5ba8d98e66351bf8b89df28e7d73ac7c06bbaa/wsmaster/codenvy-hosted-sso-server-organization/src/main/java/com/codenvy/auth/sso/server/BearerTokenValidator.java

[ibuziuk]

yes preferences API is multi tenant ready but there is no implementation of users/filters that manage different users in Che

@benoitf @gorkem my understanding is that I can move the logic of population preferences from che-starter to rh-che right now by using the same /wsmaster/api/preferences endpoint and it will become multitenant automatically once keycloak support [1] will be in place with token validator in place. Does this sound right ?

[1] eclipse-che/che#5362

[skabashnyuk]

@ibuziuk what kind of "workspace github preferences" you would like to see?

[ibuziuk]

@skabashnyuk committer name & email smth. that is set via POST /wsmaster/api/preferences

[skabashnyuk]

What is the user story? At what stage you want to set it? What is the flow?

[ibuziuk]

@skabashnyuk preferences are already set on osio via che-starter. This task is about moving this functionality from che-starter to rh-che plugin. Preferences are set just after workspace creation the user story would be "As a osio user I want to create workspace and have git preferences configured automatically"

[skabashnyuk]

So in Multi-user, Multi-tenant Che it has to be done once, before first workspace usage? Am I correct?

[ibuziuk]

@skabashnyuk yes, since committer preferences are per user and not per workspace

[ibuziuk]

BTW, since multi-tenant Che will never be idled setting committer info could be even done on first login to osio

[gorkem]

I think it is a good idea to refresh the setting per workspace create/launch in case it is updated. Users will have no idea that they need to change Che's preferences on OSIO.

[skabashnyuk]

Where do you want to store them? Why is Eclipse Che preferences not the main storage?

[l0rd]

That will be needed when che-started will be deprecated. Deferring implementation.

[l0rd]

We need to verify that eclipse-che/che#5943 will fix that

[ibuziuk]

was implemented for Che 6. Closing