Replace doctrine's deprecated fetchAll() with the new methods

[JarJak]

Feature Request

Replace doctrine's deprecated fetchAll() with the new methods.
Use fetchAllNumeric(), fetchAllAssociative() or fetchFirstColumn() instead.

Diff

        $result = $this->connection
            ->executeQuery($sql)
-            ->fetchAll(\PDO::FETCH_COLUMN);
+            ->fetchFirstColumn();

        $result = $qb->execute()
-			->fetchAll(\PDO::FETCH_ASSOC);
+        	->fetchAllAssociative();

        $result = $this->connection
            ->executeQuery($sql)
-            ->fetchColumn();
+            ->fetchOne();

[TomasVotruba]

We don't plan to add this feature now. There is a similar rule that does inversed work: /~https://github.com/rectorphp/rector/blob/master/docs/rector_rules_overview.md#methodcalltoanothermethodcallwithargumentsrector

Inversing the flow should do the work. Contribution is welcomed 👍

[TomasVotruba]

Closing as out of our scope.

[JarJak]

@TomasVotruba why? Isn't it a valid feature request?

[TomasVotruba]

We're open to contribution of this, but our main focus is on delivering of Rector on lower PHP versions. That's where most project suffer, on PHP 7.1 or even 5.6. Having Rector as composer package in 5.6 helps these projects that really suffer from upgrading.

See rectorphp/rector#5780 and rectorphp/rector#5665

[TomasVotruba]

I'm looking into this as currently upgrading such a project.