Description
With version 2.5.0.27
, repush.sh is no longer able to transfer files onto the remarkable. The reason for this is a change in the setting of teh visibleName in the metadata field. While before this was the filename including the extension, now the metadata is generated with the filename without the extension in the visibleName
-field. This causes repush.sh
to hang indefinitely as internal checks fail.
The fix for this has to be applied in two locations:
This line has to be changed to placeholder_basename="$(basename "$1" .$extension)"
, as $extension
is available from a couple of lines above.
The second location is this, in principle the same fix applies, however, $extension
is not set. A quick test of mine using "$(basename "$f" | cut -f1 -d '.')"
works like a charm, however, this will fail the moment the filename contains another .
besides the one separating the extension. As I have just briefly investigated the problem, I am not sure what's the cleanest fix for this location, hence an issue describing the fix instead of pull requesting a fix. The hack with cut
, while working, is certainly not the optimal solution.
Addendum: Due to the handling of directories (dropping a placeholder pdf and turning that into a directory), the aforementioned fix is likely not that straightforward. I currently settled for using basename twice at that very location to first remove a .pdf
-extension and then removing a .epub
-extension, which works well enough for me. However, this is likely breaking directory pushing, so it likely needs to be implemented a little more carefully, with consideration for the directory pushing implementation.