From 78575431c175a7664ac3a8ae1a8351a9e3395a28 Mon Sep 17 00:00:00 2001
From: Chris Hill-Scott <me@quis.cc>
Date: Thu, 1 Feb 2018 13:56:59 +0000
Subject: [PATCH] Use `<button>` not `<input>`s for form submission
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Both `<button type='submit'>Submit<button>` and
`<input type='submit' value='Submit'>` can be used to submit a form.

Historically `<input>` has been preferred because it’s better-supported
by IE6 in that:
- the `submit` attribute is mandatory on `<button>`, not on `<input>`
- the `innerHTML` of a button will be submitted to the server, not the
  value (as in other browsers)

Reasons to now use `<button>` instead:
- IE6/7 support is no longer a concern (especially with deprecation of
  TLS 1.0 on the way)
- Because an `<input>` element can’t have children, the pseudo-element
  hack[1] used to ensure the top edge of the button is clickable doesn’t
  work.

Fixes #545

1. alphagov/govuk_frontend_toolkit@24e1906#diff-ef0e4eb6f1e90b44b0c3fe39dce274a4R79
---
 app/views/snippets/buttons_button.html          | 2 +-
 app/views/snippets/buttons_button_disabled.html | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/snippets/buttons_button.html b/app/views/snippets/buttons_button.html
index b4e087828..80d447088 100644
--- a/app/views/snippets/buttons_button.html
+++ b/app/views/snippets/buttons_button.html
@@ -1 +1 @@
-<input class="button" type="submit" value="Save and continue">
+<button class="button" type="submit">Save and continue</button>
diff --git a/app/views/snippets/buttons_button_disabled.html b/app/views/snippets/buttons_button_disabled.html
index 9ab148e78..23314c9fe 100644
--- a/app/views/snippets/buttons_button_disabled.html
+++ b/app/views/snippets/buttons_button_disabled.html
@@ -1 +1 @@
-<input class="button" type="submit" value="Save and continue" disabled="disabled" aria-disabled="true">
+<button class="button" type="submit" disabled="disabled" aria-disabled="true">Save and continue</button>