From 3f341b3d63f9f8a9a1c88490314c0532f4b00ff9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kjartan=20M=C3=BDrdal?= Date: Mon, 26 Jun 2017 13:40:51 +0200 Subject: [PATCH 1/2] Fix a mistake in cache control documentation The value should be no-store, was no-cache. --- docs/writing_a_plugin.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/writing_a_plugin.md b/docs/writing_a_plugin.md index 066b048..cac91be 100644 --- a/docs/writing_a_plugin.md +++ b/docs/writing_a_plugin.md @@ -85,7 +85,7 @@ When the client (i.e., Qlik Sense) calls the RPC method `GetCapabilities`, the p When a function call is made from the UI, the engine calls the `ExecuteFunction` RPC method in your plugin. This method must delegate the call to the correct implementation of your functions. In the Python examples, we use the `getattr()` method and a dictionary that maps the function ID (which is sent in the request header) to the implemented function name. For more information, see [Writing an SSE plugin using Python](../examples/python/README.md). ## Cache control -The default behavior of the Qlik engine is to cache results from computations in order to reduce the workload and speed up response time. This is valid as well for computations performed by SSE plugins. For some cases caching might be undesirable and it is possible to toggle it off per request. When `EvaluateScript` or `ExecuteFunction` are called the http header key:value pair `qlik-cache:no-cache` can be set in either the initial or trailing header data of the response. This functionality is demonstrated in the [Hello world example](../examples/python/HelloWorld/README.md#nocache-function). +The default behavior of the Qlik engine is to cache results from computations in order to reduce the workload and speed up response time. This is valid as well for computations performed by SSE plugins. For some cases caching might be undesirable and it is possible to toggle it off per request. When `EvaluateScript` or `ExecuteFunction` are called the http header key:value pair `qlik-cache:no-store` can be set in either the initial or trailing header data of the response. This functionality is demonstrated in the [Hello world example](../examples/python/HelloWorld/README.md#nocache-function). Caching is automatically turned off as well if a request fails due to the communication failure or an exception is raised during a call. From 5d8a3dd9d22dd0114ca451a223c4b2cae23d560e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kjartan=20M=C3=BDrdal?= Date: Mon, 26 Jun 2017 13:45:49 +0200 Subject: [PATCH 2/2] Removing an unwanted comment from documentation --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index bbeea8d..f470d1a 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -70,7 +70,7 @@ git push -u myfork my-feature-or-bugfix Before creating a Pull Request, make sure the following items are satisfied: -- CircleCI is green (OBS!! This does not work with SSE yet right?) +- CircleCI is green - Commit message format is followed - [CLA](#cla) is signed