Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the two twig tainting approaches #109

Closed
micheh opened this issue Dec 5, 2020 · 3 comments
Closed

Document the two twig tainting approaches #109

micheh opened this issue Dec 5, 2020 · 3 comments
Assignees
@adrienlucas
Labels
documentation Improvements or additions to documentation

Comments

@micheh
Copy link
Contributor

micheh commented Dec 5, 2020

#61 added support for Twig taint analysis with two different approaches (file analyzer and cached template files).

According to the pull request, "The two have their own advantages.". Unfortunately, it is not documented what the differences and advantages are of each approach.
@seferov seferov added the documentation Improvements or additions to documentation label Dec 5, 2020
@seferov
Copy link
Member

seferov commented Dec 5, 2020

@adrienlucas could you please help with this?

@adrienlucas
Copy link
Contributor

@seferov @micheh yep, i'll take some time this week to explain the two approaches in the documentation !

@adrienlucas adrienlucas mentioned this issue Dec 14, 2020
Merged
@adrienlucas
Copy link
Contributor

@micheh please check out #121 and let me know if you find it sufficiently useful or if it stills lake some informations you would like !

@seferov seferov closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrienlucas adrienlucas

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrienlucas @seferov @micheh