Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange HTML so that the search bar is part of the main element #3398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 24, 2024

Fixes #3252

@jcoyne jcoyne added this to the 9.X milestone Oct 24, 2024
@cbeer
Copy link
Member

cbeer commented Oct 24, 2024

I'm not sure I understand the motivation for this change, but this seems like it could be incredibly disruptive to downstream applications are require a lot more overriding to recreate fairly common layout patterns:

Screenshot 2024-10-24 at 10 41 09

Screenshot 2024-10-24 at 10 41 24

Screenshot 2024-10-24 at 10 42 11

Screenshot 2024-10-24 at 10 42 56

@jcoyne
Copy link
Member Author

jcoyne commented Oct 24, 2024

I agree that this may be a challenge for adopters to take on. I believe this provides better semantics for accessibility. I believe this was raised by Darcy when looking at Geoblacklight (see #3252).

While implementing this it felt like our existing layouts (with content_for) made this a challenge to implement easily.

@dbranchini
Copy link

Let's close as won't do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure semantic HTML
3 participants