Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyOpenSci review] develop plan on whether to put nanoplots code into separate library #542

Closed
rich-iannone opened this issue Dec 2, 2024 · 1 comment

Comments

@rich-iannone
Copy link
Member

From the pyOpenSci comment:

issue (_utils_nanoplots.py): I am a little on the fence about this file. It seems a little out of place, and I would not be surprised if this was extracted in its own package, just like htmltools. It has a LOT of content, its scope is way bigger than other files: data validation, statistic computation, and the actual SVG build. The thousand lines long function seems high maintenance as well.

pyOpenSci/software-submission#202 (comment)

@machow
Copy link
Collaborator

machow commented Dec 12, 2024

We plan to circle back to this, and have noted it, but I'm going to close here for now.

@machow machow closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants