Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vortex 1.8 #4

Closed
pikdum opened this issue Apr 20, 2023 · 6 comments
Closed

Vortex 1.8 #4

pikdum opened this issue Apr 20, 2023 · 6 comments

Comments

@pikdum
Copy link
Owner

pikdum commented Apr 20, 2023

Will need to figure out a way to support Vortex 1.8, eventually.

Some thoughts:

  • can I start Vortex in a game's Proton WINEPREFIX, using Wine 8.4+, referencing .NET and other Vortex dependencies installed elsewhere?
    • if so, then that would remove the need for skyrim-post-deploy.sh
    • and make more games work out of the box, like Fallout 4 and other Bethesda games that expect Vortex to have access to game files in Documents/
  • could Vortex be distributed as a Flatpak?
@sonic2kk
Copy link

Building a version of Proton based on Wine 8.4 or above is likely the first step. Unless Proton 8.0 or Bleeding Edge is patched to include the missing Wine call, Proton-tkg may be needed to accomplish this. However I am not sure what compatibility will be like across distros. For the purposes of this project, it should be fine as the Steam Deck should be compatible.

There may be other issues that arise once a build of Proton with the missing method is implemented. There may be other missing calls, or compatibility may be broken for other reasons.

If Proton 8.0 doesn't work, then a build of Proton-tkg using the latest Bleeding Edge Proton could be checked. This should be available from the wine-tkg-git GitHub Actions. I am not sure how Valve manage their Bleeding Edge but I don't believe it's based on the latest Wine staging. Still, there's a chance things like this may be patched in for their Bleeding Edge build.

If no pre-existing builds of Proton have the required patch (or patches), a manual build of Proton based on Wine 8.4 or above may be needed. The tkg build script should allow for this.


Once a version of Proton is found that can run Vortex, compatibility will need to be tested. Hopefully there are no breakages. If the issue ends up solely being that a newer Wine version is required, then STL can be updated to use a newer Wine build at least temporarily. If a custom Tkg build is required then I can find a way to host this and have STL download it. This was done previously a long time ago when a custom Wine build was needed for MO2.

However, if compatibility with Vortex is broken, that will also need to be investigated. I don't use Vortex, so I may be limited in what I can do to investigate and fix any compatibility issues if any are on the STL side.

I'm happy to do what I can to help out and submit fixes for STL. Of course, anyone else is free to contribute as well, something I'm trying to improve at is giving others the opportunity to collaborate when they have a desire to.

I would humbly ask that, where possible, we can implement improvements to STL upstream. In other words, getting fixes into STL upstream instead of having them specific to this project :-)

Thanks!

@sonic2kk
Copy link

sonic2kk commented Apr 20, 2023

and make more games work out of the box, like Fallout 4 and other Bethesda games that expect Vortex to have access to game files in Documents/

May be possible to force Vortex and those games to symlink to the Documents folder. This can be done with winecfg, likely can be done with some Winecfg/Winetricks commands as well. Though this may impact game saves.

Vortex Flatpak

From what I have seen, and take it with a grain of salt, but distributing Wine applications as Flatpak appears to be a headache. I'm also not sure it would really solve anything, as if Vortex updates, the Flatpak would need to be updated and tested anyway. Controlling how Vortex updates with a custom build may be problematic. Not to mention the maintenance costs, it would essentially be maintaining a separate build of Vortex.


As for referencing DotNet elsewhere, there is a DOTNET_ROOT variable that can be set. I am not sure how this works or if it would work in this case, it may be worth investigating though.

@sonic2kk
Copy link

Quick follow up for consistency with sonic2kk/steamtinkerlaunch#792: The issue is indeed an incompatibility with Wine. A build of Proton-tkg based on Wine 8.6 worked with at least booting up Vortex.

@sonic2kk
Copy link

sonic2kk commented May 8, 2023

Vortex 1.8.1 Beta now works with GE-Proton8-2. The breakage with DiscardVirtualMemory is a result of Chromium requiring this stub in Wine. See this Wine-GE patch (which was also included in GE-Proton8-2): GloriousEggroll/wine-ge-custom@ef4e70b

This issue can probably be closed as the latest GE-Proton will fix it. The upgrade path is much more straightforward than downloading a nightly Proton-tkg build.

@sonic2kk
Copy link

The note on the readme is not correct anymore as Vortex 1.8 does work with GE-Proton8-2 as noted above.

@pikdum
Copy link
Owner Author

pikdum commented May 28, 2023

Fixed. More details here: sonic2kk/steamtinkerlaunch#806

@pikdum pikdum closed this as completed May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants