Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Suppress panic error message in logs while running calls from PolkadotJS #11828

Open
2 tasks done
EgorPopelyaev opened this issue Jul 13, 2022 · 2 comments
Open
2 tasks done

Suppress panic error message in logs while running calls from PolkadotJS #11828

EgorPopelyaev opened this issue Jul 13, 2022 · 2 comments
Labels
C1-low PR touches the given topic and has a low impact on builders. I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@EgorPopelyaev
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

Currently if some JSON-RPC call triggered from PolkadotJS, it leads to the runtime throwing panic error. For example, if the Core_execute_block is called manually, the following error is displayed in the logs.

According to the @tomaka this behavior is right and the error message should not be displayed in the logs.

Steps to reproduce

No response
@EgorPopelyaev EgorPopelyaev added I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. C1-low PR touches the given topic and has a low impact on builders. labels Jul 13, 2022
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Jul 13, 2022
@pepyakin
Copy link
Contributor

FWIW, I was not able to access the logs. Could you copy the example log here?

@bkchr
Copy link
Member

bkchr commented Jul 16, 2022

This will not happen anymore when we enable the following feature:

substrate/primitives/io/Cargo.toml

Line 89 in 4a19d40

improved_panic_error_reporting = []

@ordian ordian mentioned this issue Nov 22, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C1-low PR touches the given topic and has a low impact on builders. I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pepyakin @bkchr @EgorPopelyaev