Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethereum-types/std always pulls in codec #475

Closed
vorot93 opened this issue Dec 8, 2020 · 2 comments · Fixed by #664
Closed

ethereum-types/std always pulls in codec #475

vorot93 opened this issue Dec 8, 2020 · 2 comments · Fixed by #664

Comments

@vorot93
Copy link
Contributor

vorot93 commented Dec 8, 2020

The correct logic should be "pull codec/std if codec is enabled".
@ordian
Copy link
Member

ordian commented Dec 8, 2020

this is fixed only in cargo nightly: rust-lang/cargo#8832

@ordian
Copy link
Member

ordian commented Dec 8, 2020

specifically, this line

parity-common/primitive-types/Cargo.toml

Line 20 in 54076a5

std = ["uint/std", "fixed-hash/std", "impl-codec/std"]
pulls in codec, this could be fixed by enabling nightly feature mentioned above

@ordian ordian mentioned this issue Aug 5, 2021
Closed
@ordian ordian mentioned this issue Mar 1, 2022
Closed
@ordian ordian mentioned this issue Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

primitive-types: use weak dep feature paritytech/parity-common
2 participants
@vorot93 @ordian