From 989df64fa23f5151eeacff670fa8473f2283efde Mon Sep 17 00:00:00 2001 From: ericturf Date: Fri, 24 Aug 2018 18:04:36 -0400 Subject: [PATCH 1/2] feat:added no content hashing option to build cli --- src/Bundler.js | 2 +- src/cli.js | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Bundler.js b/src/Bundler.js index 0b89bc1d459..c0e745ea2dd 100644 --- a/src/Bundler.js +++ b/src/Bundler.js @@ -335,7 +335,7 @@ class Bundler extends EventEmitter { if (this.options.throwErrors && !this.hmr) { throw err; - } else if (process.env.NODE_ENV === 'production' || !initialised) { + } else if (!this.options.watch || !initialised) { await this.stop(); process.exit(1); } diff --git a/src/cli.js b/src/cli.js index 1723c1cbd47..06c1c808d9c 100755 --- a/src/cli.js +++ b/src/cli.js @@ -132,6 +132,7 @@ program .option('--no-minify', 'disable minification') .option('--no-cache', 'disable the filesystem cache') .option('--no-source-maps', 'disable sourcemaps') + .option('--no-content-hash', 'disable content hashing') .option( '--experimental-scope-hoisting', 'enable experimental scope hoisting/tree shaking support' @@ -189,8 +190,11 @@ async function bundle(main, command) { const Bundler = require('../'); if (command.name() === 'build') { - command.production = true; - process.env.NODE_ENV = process.env.NODE_ENV || 'production'; + command.watch = false; + process.env.NODE_ENV = + process.env.NODE_ENV || command.contentHash + ? 'production' + : 'development'; } else { process.env.NODE_ENV = process.env.NODE_ENV || 'development'; } From c52bae0745d900c066b03787d72b7d62c84d1384 Mon Sep 17 00:00:00 2001 From: Devon Govett Date: Mon, 24 Sep 2018 20:28:38 -0700 Subject: [PATCH 2/2] Update cli.js --- src/cli.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/cli.js b/src/cli.js index 697151c1342..f94cd4edcf7 100755 --- a/src/cli.js +++ b/src/cli.js @@ -194,11 +194,8 @@ async function bundle(main, command) { } if (command.name() === 'build') { - command.watch = false; - process.env.NODE_ENV = - process.env.NODE_ENV || command.contentHash - ? 'production' - : 'development'; + command.production = true; + process.env.NODE_ENV = process.env.NODE_ENV || 'production'; } else { process.env.NODE_ENV = process.env.NODE_ENV || 'development'; }